RussellSpitzer commented on code in PR #7361:
URL: https://github.com/apache/iceberg/pull/7361#discussion_r1176960270
##########
core/src/main/java/org/apache/iceberg/actions/RewriteDataFilesCommitManager.java:
##########
@@ -199,12 +201,28 @@ public void offer(RewriteFileGroup group) {
commitReadyCommitGroups();
}
+ /**
Review Comment:
This method confuses me a bit,
1. It's called failedRewrite but sounds like its only for a very specific
case of failure
2. It will never actually succeed since if it is called when service is
closed it will fail the precondition and throw an exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
