[ https://issues.apache.org/jira/browse/IGNITE-530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934918#comment-14934918 ]
Anton Vinogradov commented on IGNITE-530: ----------------------------------------- Lalit, Thanks for fixes! But pull request still contains a lot of codestyle issues. for example: 1) if (value != null){ getStreamer().addData(value); } //redundant braces should re removed. 2) BlockingQueue<String> tweetQueue = new LinkedBlockingQueue<String>(bufferCapacity); client = getStreamingEndpoint(tweetQueue); //newline missed 3) }catch (Exception e){ //no op } //No-op instead of //no op. Possible, error should be logged instead of //No-op. Possible, more specified type of Exception should be handled. 4) please check that 120 symbols limit is not exceeded at code & comments. Please check and fix all simillar issues. > Implement IgniteTwitterStreamer to stream data from Twitter feeds > ----------------------------------------------------------------- > > Key: IGNITE-530 > URL: https://issues.apache.org/jira/browse/IGNITE-530 > Project: Ignite > Issue Type: Sub-task > Components: streaming > Reporter: Dmitriy Setrakyan > Assignee: Lalit Kumar Jha > > We have {{IgniteDataStreamer}} which is used to load data into Ignite under > high load. It was previously named {{IgniteDataLoader}}, see ticket > IGNITE-394. > We should create {{IgniteTwitterStreamer}} which will consume messages from > Twitter and stream them into Ignite caches. > More details to follow, but to the least we should be able to: > * Convert Twitter data to Ignite data using an optional pluggable converter. > * Specify the cache name for the Ignite cache to load data into. > * Specify other flags available on {{IgniteDataStreamer}} class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)