[ https://issues.apache.org/jira/browse/IGNITE-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035809#comment-15035809 ]
Artem Shutak edited comment on IGNITE-1864 at 12/2/15 6:13 PM: --------------------------------------------------------------- The following points should be discussed in process of review: # {{CacheJndiTmFactory}} #* Should we have {{setInitialContextEnvironment}} or not? Map vs Hashtable. See http://docs.oracle.com/javase/jndi/tutorial/basics/prepare/initial.html #* jndiNames - single or plurale jndi name(s) # {{CacheReflectionTmFactory}}. I think there is no need to have that factory at all. # Where out-of-the-box factories should be listed? Currently they described in javadoc to {TransactionConfiguration.setTxManagerFactory()}. # Can {{Factory.create()}} returns {{null}} value or not? In current implementation exception will be thrown. was (Author: ashutak): The following points should be discussed in process of review: # {{CacheJndiTmFactory}} #* Should we have {{setInitialContextEnvironment}} or not? Map vs Hashtable. See http://docs.oracle.com/javase/jndi/tutorial/basics/prepare/initial.html #* jndiNames - single or plurale jndi name(s) # {{CacheReflectionTmFactory}}. I think there is no need to have that factory at all. # Where out-of-the-box factories should be listed? Currently they described in javadoc to {TransactionConfiguration.setTxManagerFactory()}. > Cannot configure jndiNames for CacheJndiTmLookup > ------------------------------------------------- > > Key: IGNITE-1864 > URL: https://issues.apache.org/jira/browse/IGNITE-1864 > Project: Ignite > Issue Type: Bug > Components: general > Reporter: Yakov Zhdanov > Assignee: Artem Shutak > Priority: Critical > Fix For: 1.6 > > > Since user have an ability to configure only lookup class name via > org.apache.ignite.configuration.TransactionConfiguration#getTxManagerLookupClassName, > he lacks ability to properly configure all of its properties. > This seems to be a general problem for this approach -- This message was sent by Atlassian JIRA (v6.3.4#6332)