[ 
https://issues.apache.org/jira/browse/IGNITE-12808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133031#comment-17133031
 ] 

Andrey Mashenkov commented on IGNITE-12808:
-------------------------------------------

>>I destroyed and created cache before each test. Why it doesn't test anything? 
>>I don't understand you

Got it. Sorry, I've missed this.  But why you use internal API for cache 
creation\removal? 
Such code looks like a hack (a user will never do that) and harder to 
understand from one side, and later, we can miss a bug if some assumption will 
be "broken" outside of dynamicCacheStart method.
I think there should be a javadoc to 'cacheCreate' method (in test class) or 
in-place comment to method usage which disclosure the motivation.

>>No, indexing is enabled not on client, but on srv1.
Sorry. I can't find "testClientReconnect*2*" in the PR (testClientReconnect 
only). Please, check if you push it. The test itself looks ok.

>>[~amashenkov] And what about this variant. I suppose it is EXACTLY what you 
>>mean.
Yes, you got it right. Please add this one as well. I'd  
"performQueryingIntegrityCheck(clie)" to the end of the test just to make sure 
client is able to run queries.

 

> Allow create tables for existing caches
> ---------------------------------------
>
>                 Key: IGNITE-12808
>                 URL: https://issues.apache.org/jira/browse/IGNITE-12808
>             Project: Ignite
>          Issue Type: New Feature
>          Components: sql
>            Reporter: Mikhail Cherkasov
>            Assignee: Ivan Daschinskiy
>            Priority: Major
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> If you have a big cache with a lot of data and you need to index it, right 
> now you have to destroy cache and create a new one to index your data.  Or 
> create a new cache with a table and reload it to  data to the new cache which 
> definitely is time-consuming and super inconvenient.
> I believe we can allow users to create tables for existing caches.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to