[
https://issues.apache.org/jira/browse/IGNITE-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665906#comment-15665906
]
Alexey Kuznetsov commented on IGNITE-3066:
------------------------------------------
Roman,
Now code looks good for me, except following:
# I think it will be better to handle {{NumberFormatException}} in more
informative way: print "bad value" in exception, or pass
{{NumberFormatException}} as cause.
# {{GridRedisIncrDecrCommandHandler#makeResponse}} contains very tricky code:
{code}
return GridRedisProtocolParser.toInteger(new
BigDecimal((Long)restRes.getResponse()).toString());
{code}
In order to convert to integer we use {{BigDecimal}} and cast to {{Long}} ???
I will ask Andrey Novikov and Valentine Kulichenko to take a look on you PR and
after that this PR could be merged I think.
> Set of Redis commands that can be easily implemented via existing REST
> commands
> -------------------------------------------------------------------------------
>
> Key: IGNITE-3066
> URL: https://issues.apache.org/jira/browse/IGNITE-3066
> Project: Ignite
> Issue Type: Sub-task
> Reporter: Roman Shtykh
> Assignee: Roman Shtykh
>
> As the 1st iteration of IGNITE-2788 the following commands can be implemented
> via existing REST commands,
> GET
> MGET
> SET
> MSET
> INCR
> DECR
> INCRBY
> DECRBY
> APPEND
> STRLEN
> GETSET
> SETRANGE
> GETRANGE
> DEL
> EXISTS
> DBSIZE
> http://redis.io/commands
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
