[
https://issues.apache.org/jira/browse/IGNITE-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905194#comment-15905194
]
Vyacheslav Daradur edited comment on IGNITE-4211 at 3/10/17 2:44 PM:
---------------------------------------------------------------------
[~avinogradov],
bq.Please, stop comments removal
Sorry about that) I had seen places which should be improved.
Thank you for your notes.
You are right. I missed them.
- The Spring had changed error-message in
org.springframework.beans.factory.NoSuchBeanDefinitionException, and the
message differed from expected in tests.
- In the grid-cfg-2-grids.xml - 'singleton="true"' needs to be replaced with
'scope="singlton"' according to the new DTD, but I just remove it, because
scope is singlton by default and this attribute is redundant.
([spring-docs|http://docs.spring.io/spring/docs/current/spring-framework-reference/htmlsingle/#beans-factory-scopes-singleton])
I have fixed it.
Additional:
- Changed catch-block of new get-method according to spring-docs
- Added basic tests for the whole SpringCache class
Sent to [ci.tests.|http://ci.ignite.apache.org/viewQueued.html?itemId=492802]
Waiting for tests results.
was (Author: daradurvs):
[~avinogradov],
bq.Please, stop comments removal
Sorry about that. I had seen places which should be improved.
Thank you for your notes.
You are right. I missed it.
- The Spring had changed error-message in
org.springframework.beans.factory.NoSuchBeanDefinitionException, and the
message differed from expected in tests.
- In the grid-cfg-2-grids.xml - 'singleton="true"' needs to be replaced with
'scope="singlton"' according to the new DTD, but I just remove it, because
scope is singlton by default and this attribute is redundant.
([spring-docs|http://docs.spring.io/spring/docs/current/spring-framework-reference/htmlsingle/#beans-factory-scopes-singleton])
I have fixed it.
Additional:
- Changed catch-block of new get-method according to spring-docs
- Added basic tests for the whole SprigCache class
Sent to [ci.tests.|http://ci.ignite.apache.org/viewQueued.html?itemId=492802]
Waiting for tests results.
> Update Spring dependency to latest stable version
> -------------------------------------------------
>
> Key: IGNITE-4211
> URL: https://issues.apache.org/jira/browse/IGNITE-4211
> Project: Ignite
> Issue Type: Improvement
> Components: build
> Affects Versions: 1.7
> Reporter: Sergey Kozlov
> Assignee: Vyacheslav Daradur
> Fix For: 2.0
>
>
> It seems the Spring dependency looks outdated for now. Apache Ignite still
> uses 4.1.0 released two years ago. Could we to update to latest stable
> version (4.3.4 at the moment)?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
