[
https://issues.apache.org/jira/browse/IGNITE-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934906#comment-15934906
]
Anton Vinogradov edited comment on IGNITE-4211 at 3/21/17 5:14 PM:
-------------------------------------------------------------------
[~daradurvs]
Could you please start review with upsourse
(https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewWithUpsource)?
This will allow to check changes in easier way.
1) Is there any reason to add GridSpringSyncCacheTestService?
Is it possible to add cacheableSync() to GridSpringDynamicCacheTestService?
1.1) You should not call SpringCache.get(key, clo) directly.
@Cacheable(sync=true) is responsible for that, since clo is an aop'ed
cacheableSync() in this case.
test should be pretty similar to regular get test:
{noformat}
public void testDynamicCacheSync() throws Exception {
Runable = ...
for (int i = 0; i < entries_num; i++) {
sync
assertEquals("value" + i, dynamicSvc.cacheableSync(i));
}
runables.start()
runables.join();
assertEquals(entries_num, dynamicSvc.called());
{noformat}
was (Author: avinogradov):
[~daradurvs]
Could you please start review with upsourse
(https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewWithUpsource)?
This will allow to check changes in easier way.
1) Is there any reason to add GridSpringSyncCacheTestService?
Is it possible to add cacheableSync() to GridSpringDynamicCacheTestService?
1.1) You should not call SpringCache.get(key, clo) directly.
@Cacheable(sync=true) is responsible for that, since clo is an aop'ed
cacheableSync() in this case.
test should be pretty similar to regular get test:
{noformat}
public void testDynamicCacheSync() throws Exception {
Runable = ...
for (int i = 0; i < entries_num; i++) {
sync
assertEquals("value" + i, dynamicSvc.cacheableSync(i));
}
runables.start()
assertEquals(entries_num, dynamicSvc.called());
{noformat}
> Update Spring dependency to latest stable version
> -------------------------------------------------
>
> Key: IGNITE-4211
> URL: https://issues.apache.org/jira/browse/IGNITE-4211
> Project: Ignite
> Issue Type: Improvement
> Components: build
> Affects Versions: 1.7
> Reporter: Sergey Kozlov
> Assignee: Vyacheslav Daradur
> Fix For: 2.0
>
>
> It seems the Spring dependency looks outdated for now. Apache Ignite still
> uses 4.1.0 released two years ago. Could we to update to latest stable
> version (4.3.4 at the moment)?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
