[ 
https://issues.apache.org/jira/browse/IGNITE-6030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200116#comment-16200116
 ] 

Ivan Rakov edited comment on IGNITE-6030 at 10/11/17 11:28 AM:
---------------------------------------------------------------

Vladimir, thanks!
I fully agree with points 1, 2, 8, 9, 10, 11, 12, 13, 14 (yes, 
metricsSubIntervalCount is better), 16.
About 17 - let's fix XML configs under separate ticket. Old configuration is 
fully compatible, so Ignite should start fine from old XML config. I'll fix 
configs in examples though.
About javadocs - I'll get rid of "Page Memory" and "Persistent Store" mentions 
and will try to describe thing in terms of data storage.

About methods for configuring store path - I'd prefer next:
* storagePath - for partition and index files
* walPath - for WAL
* walArchivePath - for WAL archive


was (Author: ivan.glukos):
Vladimir, thanks!
I fully agree with points 1, 2, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14 (yes, 
metricsSubIntervalCount is better), 16.
About 17 - let's fix XML configs under separate ticket. Old configuration is 
fully compatible, so Ignite should start fine from old XML config. I'll fix 
configs in examples though.
About javadocs - I'll get rid of "Page Memory" and "Persistent Store" mentions 
and will try to describe thing in terms of data storage.

About methods for configuring store path - I'd prefer next:
* storagePath - for partition and index files
* walPath - for WAL
* walArchivePath - for WAL archive

> Allow enabling persistence per-cache
> ------------------------------------
>
>                 Key: IGNITE-6030
>                 URL: https://issues.apache.org/jira/browse/IGNITE-6030
>             Project: Ignite
>          Issue Type: New Feature
>          Components: persistence
>    Affects Versions: 2.1
>            Reporter: Alexey Goncharuk
>            Assignee: Ivan Rakov
>            Priority: Critical
>              Labels: important
>             Fix For: 2.3
>
>
> Also, when cache native persistence is disabled, we need to make sure that 
> different {{CacheStores}} can be configured on per-cache basis.
> New storage configuration design draft:
> {noformat}
> DataStorageConfiguration
>       // memory configuration
>       getConcurrencyLevel
>       getDefaultDataRegionConfiguration
>       getDataRegionConfigurations
>       getPageSize
>       getSystemRegionInitialSize
>       getSystemRegionMaxSize
>       // persistence coniguration
>       getCheckpointingFrequency
>       getCheckpointingPageBufferSize
>       getCheckpointingThreads
>       getCheckpointWriteOrder
>       getFileIOFactory
>       getLockWaitTime
>       getPersistentStorePath
>       getRateTimeInterval
>       getSubIntervals
>       getTlbSize
>       getWalArchivePath
>       getWalAutoArchiveAfterInactivity
>       getWalFlushFrequency
>       getWalFsyncDelayNanos
>       getWalHistorySize
>       getWalMode
>       getWalRecordIteratorBufferSize
>       getWalSegments
>       getWalSegmentSize
>       getWalStorePath
>       isAlwaysWriteFullPages
>       isMetricsEnabled
>       isWriteThrottlingEnabled
> DataRegionConfiguration
>       // memory policy configuration
>       isPersistenceEnabled (default = false)
>       getEmptyPagesPoolSize
>       getEvictionThreshold
>       getInitialSize
>       getMaxSize
>       getName
>       getPageEvictionMode
>       getRateTimeInterval
>       getSubIntervals
>       getSwapFilePath
>       isMetricsEnabled
> {noformat}
> New metrics and MBean classes:
> {noformat}
> PersistenceMetrics -> DataStorageMetrics
> PersistenceMetricsMXBean -> DataStorageMetricsMXBean
> MemoryMetrics -> DataRegionMetrics
> MemoryMetricsMXBean -> DataRegionMetricsMXBean
> {noformat}
> Please note that old versions of all classes and methods are retained in 
> codebase as deprecated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to