[ https://issues.apache.org/jira/browse/IGNITE-6899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337823#comment-16337823 ]
Oleg Ignatenko commented on IGNITE-6899: ---------------------------------------- I re-checked the most recent changes: unit tests pass as before meaning functionality keeps working. There is an error added in examples code though: class {{MovieFitnessFunction}} line 98 typo "generes" instead of "genres". This error broke compilation of examples and Teamcity check but after I corrected it in my branch the rest went just excellent: Teamcity checks for javadocs [all passed on my branch|https://ci.ignite.apache.org/viewLog.html?buildId=1059292&]. For the sake of completeness while skimming over code I noticed some non-critical deviations from Ignite coding style but I don't see a pressing need to polish these now. ----- [~chief] I would appreciate if you take a look at code in [this branch|https://github.com/techbysample/ignite/tree/ignite-6899]. I am primarily interested to know if it's good enough to merge to master or something else needs to be done. (above mentioned typo in {{MovieFitnessFunction}}, it definitely needs to be fixed prior to merge but that's minor) > Adding GA Grid to Apache Ignite ML module. > ------------------------------------------ > > Key: IGNITE-6899 > URL: https://issues.apache.org/jira/browse/IGNITE-6899 > Project: Ignite > Issue Type: New Feature > Components: ml > Reporter: Yury Babak > Assignee: Turik Campbell > Priority: Major > Fix For: 2.5 > > Attachments: coverage.zip > > > We want to add GA Grid to our ML Module. > This is the first iteration of this integration. On this step we will simple > add GA Grid to the separate package in ML module. > (i) This is a good package for GA Grid: org.apache.ignite.ml.genetic > (i) For GA Grid we need unit tests as well as examples -- This message was sent by Atlassian JIRA (v7.6.3#76005)