[ https://issues.apache.org/jira/browse/IGNITE-6842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421623#comment-16421623 ]
Maxim Muzafarov commented on IGNITE-6842: ----------------------------------------- Folks, Let me describe some significat changes of whole this PR: # Added new {{stopAllGridsSilently}} method which throws exception in case stopping grids, so we can see failed tests fast; # Added {{stopAllGridsSilently}} to {{afterTestsStop}} method body. This way we recommend users to expect stopping grids by default, but in case some complex stop-grid processes default behavior can be overrided; # Added assertion check of `not running grids` for the first test-cases run in {{setUp}} method body. Check can't be overrided and we are forcing users not to forget stop Ignite instances; # Introduced {{isSafeTopology}} flag. I've found test suites (e.g. classes inherited from [IgniteConfigVariationsAbstractTest.java|https://github.com/apache/ignite/pull/3542/files#diff-cd3a07ce10f21d396c1eac0c328850e0]) which don't want to stop grids between test-classes execution. That's why, we should turn off all checks by setting {{isSafeTopology = false}} for this test suites. Also, TC build: [#963 (30 Mar 18 20:06)|https://ci.ignite.apache.org/viewLog.html?buildId=1169144] looks good. I haven't found any failed test-cases caused by my changes. [~dpavlov], [~NIzhikov] Will you have time to review my changes? > Stop all nodes after test by default. > ------------------------------------- > > Key: IGNITE-6842 > URL: https://issues.apache.org/jira/browse/IGNITE-6842 > Project: Ignite > Issue Type: Improvement > Reporter: Alexei Scherbakov > Assignee: Maxim Muzafarov > Priority: Major > Labels: newbie > Fix For: 2.5 > > Attachments: IgniteStopGridsTestSuite.java, > StopGridsStateFirstTest.java, StopGridsStateSecondTest.java > > > Currently it's required to manually call stopAllGrids() after test completion. > This leads to errors in subsequent tests if someone forgets to call it and to > additional boilerplate code in tests. > Right choice is to make this default behavior. -- This message was sent by Atlassian JIRA (v7.6.3#76005)