[ 
https://issues.apache.org/jira/browse/IGNITE-8075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16450289#comment-16450289
 ] 

Pavel Tupitsyn edited comment on IGNITE-8075 at 4/24/18 5:50 PM:
-----------------------------------------------------------------

[~ivandasch] my comments:

1. {{ICluster.SetTxTimeoutOnPartitionMapExchange}} - we can set it, but we 
can't get it?
2. {{Ignite.Op}} must be internal
3. {{TransactionsImpl.WithLabel}} use {{IgniteArgumentCheck.NotNull}}. 
Debug.Assert is for checking args inside our code. All user calls must do 
exception-based arg validation.
4. {{LocalActiveTransactions}} -> {{GetLocalActiveTransactions}}


was (Author: ptupitsyn):
[~ivandasch] my comments:

1. {{ICluster.SetTxTimeoutOnPartitionMapExchange}} - we can set it, but we 
can't get it?
2. {{Ignite.Op}} must be internal
3. {{TransactionsImpl.WithLabel}} use {{IgniteArgumentCheck.NotNull}}. 
Debug.Assert is for checking args inside our code. All user calls must do 
exception-based arg validation.
4. {{LocalActiveTransactions}} -> {{LocalActiveTransactions}}

> .NET: setRollbackOnTopologyChangeTimeout, withLabel, localActiveTransactions, 
> setTxTimeoutOnPartitionMapExchange
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-8075
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8075
>             Project: Ignite
>          Issue Type: Improvement
>    Affects Versions: 2.4
>            Reporter: Alexei Scherbakov
>            Assignee: Ivan Daschinskiy
>            Priority: Major
>             Fix For: 2.6
>
>
> Neet to add new methods as part of .NET API:
> org.apache.ignite.configuration.TransactionConfiguration#txTimeoutOnPartitionMapExchange
>  - timeout for automatic rollback on exchange.
> org.apache.ignite.IgniteTransactions#withLabel - tx label
> org.apache.ignite.IgniteTransactions#localActiveTransactions - list of local 
> active transactions.
> org.apache.ignite.IgniteCluster#setTxTimeoutOnPartitionMapExchange
> Java implementation is currently available at a branch [1]
> [1] https://github.com/gridgain/apache-ignite/tree/ignite-6827-2



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to