[
https://issues.apache.org/jira/browse/IGNITE-9532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612445#comment-16612445
]
Anton Vinogradov commented on IGNITE-9532:
------------------------------------------
[~uday],
I've checked the changes, and have some comments
1) Changes like
{noformat}
if (opCtx != null && opCtx.isKeepBinary())
return delegate.contains(item);
return delegate.contains(item);
{noformat}
looks odd, you'll perform {{delegate.contains(item)}} in any case.
Is it a typo?
2) at {{GridCacheQueueProxy.withKeepBinary()}} you're creating new
{{CacheOperationContext}}.
Correct case is to use
{{org.apache.ignite.internal.processors.cache.CacheOperationContext#keepBinary}}
instead like cache do.
3) I see a lot of changes not related to the issue.
Newlines and documentation reformation.
Please rollback such changes.
4) I see you duplicated each test inside GridCacheQueueApiSelfAbstractTest.
Please find a way to reduce changes amount.
> Binary mode for Ignite Queue
> ----------------------------
>
> Key: IGNITE-9532
> URL: https://issues.apache.org/jira/browse/IGNITE-9532
> Project: Ignite
> Issue Type: New Feature
> Components: binary, data structures
> Reporter: Uday Kale
> Assignee: Uday Kale
> Priority: Major
> Fix For: 2.8
>
>
> Add binary mode (withKeepBinary) to Data Structures Queue.
> This will allow retrieving values in binary format when needed or when class
> is not available, and will allow implementing the structures in other
> platforms (.NET, C++).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
