[ 
https://issues.apache.org/jira/browse/IGNITE-9532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16616768#comment-16616768
 ] 

Uday Kale commented on IGNITE-9532:
-----------------------------------

[~avinogradov],

Following are the replies to your comments:
 # Should have removed this. Overlooked it.
 # Will make the changes
 # I have set the Ignite recommend properties in IntelliJ. The formatting 
shortcut is making such changes. I thought it would be ok. I will revert them 
from now on.
 # Can I merge the tests into a single function, instead of duplicating them?

I have a question of my own:
 # Should the following unit test be successful?

{code:java}
public void testCollectionMethods() throws Exception {
        IgniteQueue<SameHashItem> queue = grid(0).queue("q1", 0, config(false));
        IgniteQueue<BinaryObject> queueBin = grid(0).queue("q1", 0, 
config(false)).withKeepBinary();

        int retries = 100;

        // Initialize queue.
        for (int i = 0; i < retries; i++) {
            queue.addAll(Arrays.asList(new SameHashItem(Integer.toString(i)), 
new SameHashItem(Integer.toString(i))));
            queueBin.addAll(Arrays.asList(sameHashBinObj(grid(0), i), 
sameHashBinObj(grid(0), i)));
        }

        assertTrue(queue.contains(new SameHashItem(Integer.toString(14))));
}

private static BinaryObject sameHashBinObj(Ignite ignite, int i) {
    return ignite.binary().toBinary(new SameHashItem(Integer.toString(i)));
}
{code}

> Binary mode for Ignite Queue
> ----------------------------
>
>                 Key: IGNITE-9532
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9532
>             Project: Ignite
>          Issue Type: New Feature
>          Components: binary, data structures
>            Reporter: Uday Kale
>            Assignee: Uday Kale
>            Priority: Major
>             Fix For: 2.8
>
>
> Add binary mode (withKeepBinary) to Data Structures Queue.
> This will allow retrieving values in binary format when needed or when class 
> is not available, and will allow implementing the structures in other 
> platforms (.NET, C++).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to