[ 
https://issues.apache.org/jira/browse/IGNITE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656712#comment-16656712
 ] 

ASF GitHub Bot commented on IGNITE-9849:
----------------------------------------

SomeFire commented on a change in pull request #38: IGNITE-9849 Remove invalid 
builds from the selection
URL: https://github.com/apache/ignite-teamcity-bot/pull/38#discussion_r226609952
 
 

 ##########
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/rest/build/GetBuildTestFailures.java
 ##########
 @@ -158,6 +164,50 @@ public TestFailuresSummary getBuildTestFails(
         return res;
     }
 
+    /**
+     * Mark builds as "valid" or "invalid" for a specific user.
+     *
+     * @param buildId Build id.
+     * @param isValid Is valid.
+     * @param field Field.
+     * @param srv Server.
+     */
+    @GET
+    @Path("condition")
+    public SimpleResult setBuildCondition(
+        @QueryParam("buildId") Integer buildId,
+        @QueryParam("isValid") Boolean isValid,
+        @QueryParam("field") String field,
+        @QueryParam("serverId") String srv) {
+        String srvId = isNullOrEmpty(srv) ? "apache" : srv;
+
+        if (buildId == null || isValid == null)
+            return new SimpleResult("<i class='fas 
fa-exclamation-circle'></i><br><br>" + (buildId == null ?
+                ("BuildId" + (isValid == null ? "and condition are" : "is")) : 
"Build condition is") + " <b>null</b>!");
+
+        final ITcHelper tcHelper = CtxListener.getTcHelper(ctx);
+
+        final ICredentialsProv prov = ICredentialsProv.get(req);
+
 
 Review comment:
   ```suggestion
   
           if (!prov.hasAccess(serverId))
               throw ServiceUnauthorizedException.noCreds(serverId);
   
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove invalid builds from the selection
> ----------------------------------------
>
>                 Key: IGNITE-9849
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9849
>             Project: Ignite
>          Issue Type: Sub-task
>            Reporter: Nikolai Kulagin
>            Assignee: Nikolai Kulagin
>            Priority: Minor
>
> In selection sometimes there are builds with abnormal values. For example, 
> the average number of failed tests is 25. But in the build [1953935] there 
> are 2939 failed tests. This is an anomalous value. Need to add the ability to 
> remove it from the selection. Build [1953935] - not valid.
> In total, 
> 1. While clicking on a point on the chart, show a button that allows marking 
> a build invalid and excludes it from further selections.
> 2. Reduce the number of erroneous exceptions. Compare the value with the 
> average, if the difference is small - ask for confirmation of the operation.
> 3. Add the ability to return an excluded build to the selection.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to