[
https://issues.apache.org/jira/browse/IGNITE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665099#comment-16665099
]
ASF GitHub Bot commented on IGNITE-9849:
----------------------------------------
SomeFire commented on a change in pull request #38: IGNITE-9849 Remove invalid
builds from the selection
URL: https://github.com/apache/ignite-teamcity-bot/pull/38#discussion_r228495040
##########
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/condition/BuildCondition.java
##########
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.ci.tcbot.condition;
+
+import java.util.Date;
+import java.util.Objects;
+
+/**
+ * Mark build as valid or invalid.
Review comment:
Clarify here: what is valid/invalid build?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove invalid builds from the selection
> ----------------------------------------
>
> Key: IGNITE-9849
> URL: https://issues.apache.org/jira/browse/IGNITE-9849
> Project: Ignite
> Issue Type: Sub-task
> Reporter: Nikolai Kulagin
> Assignee: Nikolai Kulagin
> Priority: Minor
>
> In selection sometimes there are builds with abnormal values. For example,
> the average number of failed tests is 25. But in the build [1953935] there
> are 2939 failed tests. This is an anomalous value. Need to add the ability to
> remove it from the selection. Build [1953935] - not valid.
> In total,
> 1. While clicking on a point on the chart, show a button that allows marking
> a build invalid and excludes it from further selections.
> 2. Reduce the number of erroneous exceptions. Compare the value with the
> average, if the difference is small - ask for confirmation of the operation.
> 3. Add the ability to return an excluded build to the selection.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
