[
https://issues.apache.org/jira/browse/IGNITE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670813#comment-16670813
]
ASF GitHub Bot commented on IGNITE-9849:
----------------------------------------
dspavlov commented on a change in pull request #57: IGNITE-9849 Refactor Master
trends
URL: https://github.com/apache/ignite-teamcity-bot/pull/57#discussion_r229880842
##########
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/hist/BuildsHistory.java
##########
@@ -92,25 +91,26 @@
/** */
public void initialize(ICredentialsProv prov, ServletContext context) {
- if (!prov.hasAccess(srvId))
- throw ServiceUnauthorizedException.noCreds(srvId);
+ final IStringCompactor compactor =
CtxListener.getInjector(context).getInstance(IStringCompactor.class);
ITcHelper tcHelper = CtxListener.getTcHelper(context);
- IAnalyticsEnabledTeamcity teamcity = tcHelper.server(srvId, prov);
+ ITeamcity teamcity = tcHelper.server(srvId, prov);
ITeamcityIgnitedProvider tcIgnitedProv =
CtxListener.getInjector(context)
.getInstance(ITeamcityIgnitedProvider.class);
- ITeamcityIgnited ignited = tcIgnitedProv.server(srvId, prov);
+ ITeamcityIgnited ignitedTeamcity = tcIgnitedProv.server(srvId, prov);
- int[] finishedBuildsIds =
teamcity.getBuildNumbersFromHistory(buildTypeId, branchName,
- sinceDateFilter, untilDateFilter);
+ List<Integer> finishedBuildsIds = ignitedTeamcity
+ .getFinishedBuildsCompacted(buildTypeId, branchName,
sinceDateFilter, untilDateFilter)
Review comment:
Probably we need filter out canceled builds here. New method may return
finished build, but having status Unknown. It may mean build was canceled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove invalid builds from the selection
> ----------------------------------------
>
> Key: IGNITE-9849
> URL: https://issues.apache.org/jira/browse/IGNITE-9849
> Project: Ignite
> Issue Type: Sub-task
> Reporter: Nikolai Kulagin
> Assignee: Nikolai Kulagin
> Priority: Minor
>
> In selection sometimes there are builds with abnormal values. For example,
> the average number of failed tests is 25. But in the build [1953935] there
> are 2939 failed tests. This is an anomalous value. Need to add the ability to
> remove it from the selection. Build [1953935] - not valid.
> In total,
> 1. While clicking on a point on the chart, show a button that allows marking
> a build invalid and excludes it from further selections.
> 2. Reduce the number of erroneous exceptions. Compare the value with the
> average, if the difference is small - ask for confirmation of the operation.
> 3. Add the ability to return an excluded build to the selection.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
