zjregee commented on code in PR #2228:
URL: https://github.com/apache/kvrocks/pull/2228#discussion_r1554832997
##########
src/commands/cmd_json.cc:
##########
@@ -616,6 +642,7 @@
REDIS_REGISTER_COMMANDS(MakeCmdAttr<CommandJsonSet>("json.set", 4, "write", 1, 1
MakeCmdAttr<CommandJsonObjLen>("json.objlen", -2,
"read-only", 1, 1, 1),
MakeCmdAttr<CommandJsonStrAppend>("json.strappend",
-3, "write", 1, 1, 1),
MakeCmdAttr<CommandJsonStrLen>("json.strlen", -2,
"read-only", 1, 1, 1),
- MakeCmdAttr<CommandJsonMGet>("json.mget", -3,
"read-only", 1, 1, 1), );
+ MakeCmdAttr<CommandJsonMGet>("json.mget", -3,
"read-only", 1, 1, 1),
+ MakeCmdAttr<CommandJsonMSet>("json.mset", -4, "write",
1, 1, 1), );
Review Comment:
Thank you very much, but I'm still a little confused about this, is this how
it's supposed to be?
```C++
MakeCmdAttr<CommandJsonMGet>("json.mget", -3, "read-only", 1, -2, 1)
MakeCmdAttr<CommandJsonMSet>("json.mset", -4, "write", 1, -3, 3)
```
This is the syntax of json.mset.
```shell
JSON.MSET key path value [key path value ...]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
