PragmaTwice commented on code in PR #2228:
URL: https://github.com/apache/kvrocks/pull/2228#discussion_r1554833974
##########
src/commands/cmd_json.cc:
##########
@@ -616,6 +642,7 @@
REDIS_REGISTER_COMMANDS(MakeCmdAttr<CommandJsonSet>("json.set", 4, "write", 1, 1
MakeCmdAttr<CommandJsonObjLen>("json.objlen", -2,
"read-only", 1, 1, 1),
MakeCmdAttr<CommandJsonStrAppend>("json.strappend",
-3, "write", 1, 1, 1),
MakeCmdAttr<CommandJsonStrLen>("json.strlen", -2,
"read-only", 1, 1, 1),
- MakeCmdAttr<CommandJsonMGet>("json.mget", -3,
"read-only", 1, 1, 1), );
+ MakeCmdAttr<CommandJsonMGet>("json.mget", -3,
"read-only", 1, 1, 1),
+ MakeCmdAttr<CommandJsonMSet>("json.mset", -4, "write",
1, 1, 1), );
Review Comment:
Yes, that's correct too. Since the key step is 3, there is little difference
between -1 and -3 for the stop index.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
