mapleFU commented on code in PR #2389:
URL: https://github.com/apache/kvrocks/pull/2389#discussion_r1676822721
##########
src/cluster/slot_migrate.h:
##########
@@ -55,8 +55,9 @@ enum class SlotMigrationStage { kNone, kStart, kSnapshot,
kWAL, kSuccess, kFaile
enum class KeyMigrationResult { kMigrated, kExpired, kUnderlyingStructEmpty };
struct SlotMigrationJob {
- SlotMigrationJob(int slot_id, std::string dst_ip, int dst_port, int speed,
int pipeline_size, int seq_gap)
- : slot_id(static_cast<int16_t>(slot_id)),
+ SlotMigrationJob(const SlotRange &slot_range, std::string dst_ip, int
dst_port, int speed, int pipeline_size,
+ int seq_gap)
+ : slot_range(slot_range),
Review Comment:
`slot_range(slot_range)` is a bit weird since input arg and member shares
the same naming. I think rename input argument to another name is a good way
for this problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
