PokIsemaine commented on code in PR #2389:
URL: https://github.com/apache/kvrocks/pull/2389#discussion_r1676825309
##########
src/cluster/cluster.cc:
##########
@@ -214,7 +214,7 @@ Status Cluster::SetClusterNodes(const std::string
&nodes_str, int64_t version, b
if (!migrated_slots_.empty()) {
for (const auto &[slot, _] : migrated_slots_) {
if (slots_nodes_[slot] != myself_) {
- auto s = srv_->slot_migrator->ClearKeysOfSlot(kDefaultNamespace, slot);
+ auto s = srv_->slot_migrator->ClearKeysOfSlotRange(kDefaultNamespace,
{slot, slot});
Review Comment:
I will add a static function `GetPoint` in `SlotRange`. For `GetInvaild`, I
feel that it may not be suitable if it is used to replace `{-1, -1}`, because
sometimes `{-1, -1}` represents a wrong SlotRange, and sometimes represents an
empty SlotRange, depending on the context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
