[
https://issues.apache.org/jira/browse/KYLIN-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641059#comment-16641059
]
ASF GitHub Bot commented on KYLIN-3586:
---------------------------------------
asfgit commented on issue #280: KYLIN-3586 Fix remaining boxing/unboxing problem
URL: https://github.com/apache/kylin/pull/280#issuecomment-427654284
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Boxing/unboxing to parse a primitive is suboptimal
> --------------------------------------------------
>
> Key: KYLIN-3586
> URL: https://issues.apache.org/jira/browse/KYLIN-3586
> Project: Kylin
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Lijun Cao
> Priority: Major
> Fix For: v2.6.0
>
>
> An example is from HBaseLookupRowEncoder:
> {code}
> int valIdx = Integer.valueOf(Bytes.toString(qualifier));
> {code}
> valueOf returns an Integer object which would be unboxed and assigned to
> valIdx.
> Integer.parseInt() should be used instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
