[jira] [Commented] (KYLIN-3586) Boxing/unboxing to parse a primitive is suboptimal

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/KYLIN-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641070#comment-16641070
 ] 

ASF GitHub Bot commented on KYLIN-3586:
---------------------------------------

coveralls commented on issue #280: KYLIN-3586 Fix remaining boxing/unboxing 
problem
URL: https://github.com/apache/kylin/pull/280#issuecomment-427655794
 
 
   ## Pull Request Test Coverage Report for [Build 
3734](https://coveralls.io/builds/19392189)
   
   * **1** of **7**   **(14.29%)**  changed or added relevant lines in **3** 
files are covered.
   * **3** unchanged lines in **2** files lost coverage.
   * Overall coverage increased (+**0.01%**) to **23.293%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | 
[core-common/src/main/java/org/apache/kylin/common/debug/BackdoorToggles.java](https://coveralls.io/builds/19392189/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fdebug%2FBackdoorToggles.java#L117)
 | 0 | 1 | 0.0%
   | 
[core-metadata/src/main/java/org/apache/kylin/metadata/tuple/Tuple.java](https://coveralls.io/builds/19392189/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Ftuple%2FTuple.java#L179)
 | 0 | 1 | 0.0%
   | 
[jdbc/src/main/java/org/apache/kylin/jdbc/KylinClient.java](https://coveralls.io/builds/19392189/source?filename=jdbc%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjdbc%2FKylinClient.java#L179)
 | 1 | 5 | 20.0%
   <!-- | **Total:** | **1** | **7** | **14.29%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/19392189/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L553)
 | 1 | 78.12% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/19392189/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124)
 | 2 | 68.46% |
   <!-- | **Total:** | **3** |  | -->
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/19392189/badge)](https://coveralls.io/builds/19392189)
 |
   | :-- | --: |
   | Change from base [Build 3732](https://coveralls.io/builds/19385953): |  
0.01% |
   | Covered Lines: | 16301 |
   | Relevant Lines: | 69983 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Boxing/unboxing to parse a primitive is suboptimal
> --------------------------------------------------
>
>                 Key: KYLIN-3586
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3586
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Lijun Cao
>            Priority: Major
>             Fix For: v2.6.0
>
>
> An example is from HBaseLookupRowEncoder:
> {code}
>             int valIdx = Integer.valueOf(Bytes.toString(qualifier));
> {code}
> valueOf returns an Integer object which would be unboxed and assigned to 
> valIdx.
> Integer.parseInt() should be used instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)