pfzhan commented on code in PR #2089:
URL: https://github.com/apache/kylin/pull/2089#discussion_r1110728308
##########
src/spark-project/engine-spark/src/main/java/org/apache/kylin/engine/spark/merger/AfterMergeOrRefreshResourceMerger.java:
##########
@@ -170,6 +172,7 @@ public NDataLayout[] mergeNormalModel(String dataflowId,
Set<String> segmentIds,
@Override
public NDataLayout[] merge(String dataflowId, Set<String> segmentIds,
Set<Long> layoutIds,
ResourceStore remoteResourceStore, JobTypeEnum jobType, Set<Long>
partitions) {
+ // TODO checker the input layouts
Review Comment:
开 issue 直接加个注释，内部已经不让直接写 todo 了。todo 一般就是不做。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
