liukun4515 commented on code in PR #2089:
URL: https://github.com/apache/kylin/pull/2089#discussion_r1111607847
##########
src/spark-project/engine-spark/src/main/java/org/apache/kylin/engine/spark/merger/AfterBuildResourceMerger.java:
##########
@@ -52,6 +52,7 @@ public AfterBuildResourceMerger(KylinConfig config, String
project) {
@Override
public NDataLayout[] merge(String dataflowId, Set<String> segmentId,
Set<Long> layoutIds,
ResourceStore remoteResourceStore, JobTypeEnum jobType, Set<Long>
partitions) {
+ // TODO checker the input layouts
Review Comment:
> 为什么要加这个 todo。如果这边有问题，建议开个 follow up 的 issue 描述一下这边存在的问题。
commit for cleanup code:
https://github.com/apache/kylin/pull/2089/commits/169c7c1975c5cc47b21a1bd8e25b25293cfa23ee
##########
src/spark-project/engine-spark/src/main/java/org/apache/kylin/engine/spark/merger/AfterMergeOrRefreshResourceMerger.java:
##########
@@ -170,6 +172,7 @@ public NDataLayout[] mergeNormalModel(String dataflowId,
Set<String> segmentIds,
@Override
public NDataLayout[] merge(String dataflowId, Set<String> segmentIds,
Set<Long> layoutIds,
ResourceStore remoteResourceStore, JobTypeEnum jobType, Set<Long>
partitions) {
+ // TODO checker the input layouts
Review Comment:
https://github.com/apache/kylin/pull/2089/commits/169c7c1975c5cc47b21a1bd8e25b25293cfa23ee
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
