mikemccand commented on a change in pull request #815: LUCENE-8213: Introduce Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/815#discussion_r326563068
########## File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java ########## @@ -95,6 +98,11 @@ // maps queries that are contained in the cache to a singleton so that this // cache does not store several copies of the same query private final Map<Query, Query> uniqueQueries; + // Marks the inflight queries that are being asynchronously loaded into the cache + // This is used primarily to ensure that multiple threads do not trigger loading Review comment: Remove `primarily`? This is its sole purpose? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
