[ 
https://issues.apache.org/jira/browse/SOLR-13725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934933#comment-16934933
 ] 

ASF subversion and git services commented on SOLR-13725:
--------------------------------------------------------

Commit 59fe7b7d9fc7bbc26e761a6a51a32803eb024c3e in lucene-solr's branch 
refs/heads/master from Munendra S N
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=59fe7b7 ]

SOLR-13725: allow negative values for limit in TermsFacetMap

* when limit is negative all the facet values are returned
* allow mincount=0 in TermsFacetMap.


> TermsFacetMap.setLimit() unnecessarily rejects negative parameter value
> -----------------------------------------------------------------------
>
>                 Key: SOLR-13725
>                 URL: https://issues.apache.org/jira/browse/SOLR-13725
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SolrJ
>    Affects Versions: 8.2
>            Reporter: Richard Walker
>            Assignee: Munendra S N
>            Priority: Trivial
>         Attachments: SOLR-13725.patch, SOLR-13725.patch
>
>
> SolrJ's {{TermsFacetMap.setLimit(int maximumBuckets)}} rejects a negative 
> parameter value with an IllegalArgumentException "Parameter 'maximumBuckets' 
> must be non-negative".
> But a negative value for the limit parameter is accepted by Solr server, and 
> is meaningful: i.e., it means "no limit".
> The {{setLimit()}} method shouldn't reject a negative parameter value.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to