mikemccand commented on a change in pull request #815: LUCENE-8213: Introduce Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/815#discussion_r328208652
########## File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java ########## @@ -832,5 +920,25 @@ public BulkScorer bulkScorer(LeafReaderContext context) throws IOException { return new DefaultBulkScorer(new ConstantScoreScorer(this, 0f, ScoreMode.COMPLETE_NO_SCORES, disi)); } + // Perform a cache load asynchronously + private void cacheAsynchronously(LeafReaderContext context, IndexReader.CacheHelper cacheHelper) throws RejectedExecutionException { + /* + * If the current query is already being asynchronously cached, + * do not trigger another cache operation + */ + if (inFlightAsyncLoadQueries.add(in.getQuery()) == false) { + return; + } + + FutureTask<Void> task = new FutureTask<>(() -> { + DocIdSet localDocIdSet = cache(context); + putIfAbsent(in.getQuery(), localDocIdSet, cacheHelper); + + //Remove the key from inflight -- the key is loaded now + inFlightAsyncLoadQueries.remove(in.getQuery()); Review comment: Can you `assert` the return value here? I.e. we should *always* succeed in removing this query from the set. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org