jpountz commented on a change in pull request #916: LUCENE-8213: Asynchronous
Caching in LRUQueryCache
URL: https://github.com/apache/lucene-solr/pull/916#discussion_r330564331
##########
File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java
##########
@@ -832,5 +952,47 @@ public BulkScorer bulkScorer(LeafReaderContext context)
throws IOException {
return new DefaultBulkScorer(new ConstantScoreScorer(this, 0f,
ScoreMode.COMPLETE_NO_SCORES, disi));
}
+ // Perform a cache load asynchronously
+ // @return true if synchronous caching is needed, false otherwise
+ private boolean cacheAsynchronously(LeafReaderContext context,
IndexReader.CacheHelper cacheHelper) {
+ /*
+ * If the current query is already being asynchronously cached,
+ * do not trigger another cache operation
+ */
+ Object returnValue = inFlightAsyncLoadQueries.putIfAbsent(new
MapKey(in.getQuery(),
+ cacheHelper.getKey()), cacheHelper.getKey());
+
+ assert returnValue == null || returnValue == cacheHelper.getKey();
+
+ if (returnValue != null) {
+ return false;
+ }
+
+ FutureTask<Void> task = new FutureTask<>(() -> {
+ DocIdSet localDocIdSet = cache(context);
+ putIfAbsent(in.getQuery(), localDocIdSet, cacheHelper);
+
+ // Remove the key from inflight -- the key is loaded now
+ Object retValue = inFlightAsyncLoadQueries.remove(new
MapKey(in.getQuery(), cacheHelper.getKey()));
+
+ // The query should have been present in the inflight queries set
before
+ // we actually loaded it -- hence the removal of the key should be
successful
+ assert retValue != null;
+
+ if (countDownLatch != null) {
+ countDownLatch.countDown();
+ }
+
+ return null;
+ });
+ try {
+ executor.execute(task);
+ } catch (RejectedExecutionException e) {
+ // Trigger synchronous caching
+ return true;
+ }
Review comment:
Same here, we need to remove from inFlightAsyncLoadQueries on every code
path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
