chatman commented on a change in pull request #929: SOLR-13821: Package Store for storing package artefacts URL: https://github.com/apache/lucene-solr/pull/929#discussion_r331950280
########## File path: solr/core/src/java/org/apache/solr/filestore/PackageStore.java ########## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.filestore; + +import java.io.IOException; +import java.io.InputStream; +import java.nio.ByteBuffer; +import java.nio.file.Path; +import java.util.Date; +import java.util.List; +import java.util.function.Consumer; +import java.util.function.Predicate; + +import org.apache.solr.common.MapWriter; +import org.apache.solr.filestore.PackageStoreAPI.MetaData; +import org.apache.zookeeper.server.ByteBufferInputStream; + +/** The interface to be implemented by any package store provider + * * @lucene.experimental + */ +public interface PackageStore { + + /** + * Store a file into the filestore. This should ensure that it is replicated + * across all nodes in the cluster + */ + void put(FileEntry fileEntry) throws IOException; + + /** + * read file content from a given path + */ + void get(String path, Consumer<FileEntry> filecontent) throws IOException; + + /** + * Fetch a resource from another node + * internal + * + */ + boolean fetch(String path, String from); + + List<FileDetails> list(String path, Predicate<String> predicate); + + /** + * get the real path on filesystem + */ + Path getRealpath(String path); + + /** + * The type of the resource + */ + FileType getType(String path); + + public class FileEntry { + final ByteBuffer buf; + final MetaData meta; + final String path; + + FileEntry(ByteBuffer buf, MetaData meta, String path) { + this.buf = buf; + this.meta = meta; + this.path = path; + } + + public String getPath(){ + return path; + } + + + + public InputStream getInputStream() { + if(buf != null) return new ByteBufferInputStream(buf); Review comment: Please add space after if and before (. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
