[ 
https://issues.apache.org/jira/browse/SOLR-13816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946048#comment-16946048
 ] 

Chris M. Hostetter commented on SOLR-13816:
-------------------------------------------

Params that are specific to {{ExtendedDismaxQParser}} and not supported by 
{{DismaxQParser}} should not be added to {{DisMaxParams}} -- that would be 
missleading and confusing to users.

If the objective of this issue is to improve the solrj level constants to 
represent all of the params supported by  {{ExtendedDismaxQParser}}, then it 
would probably make sense to add a new {{ExtendedDisMaxParams extends 
DisMaxParams}} and put them there?

"sow" should probably be defined in {{CommonParams}} ?

Also, FWIW: once we refactor these constants out of 
{{ExtendedDismaxQParser.DMP}} and into solrj, there is no reason to keep that 
{{DMP}} interface around ... it's private so it can be removed w/o backcompat 
concerns (the only reason it, and a handful of interfaces like it still left in 
the code, ever existed is because they predates static imports in java)


> eDismax: Missing Param Constants
> --------------------------------
>
>                 Key: SOLR-13816
>                 URL: https://issues.apache.org/jira/browse/SOLR-13816
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: query parsers
>            Reporter: Jonathan J Senchyna
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently, DisMaxParams contains a mix of constants for both the DisMax and 
> eDisMax query parsers; several of the eDisMax parameters are missing though.  
> This is needed to properly add support in Spring Data Solr.  Specifically, 
> constants for the following are not defined:
>  * sow
>  * lowercaseOperators
>  * stopwords
>  * uf



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to