jpountz commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/916#discussion_r332854167
########## File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java ########## @@ -813,8 +832,23 @@ public BulkScorer bulkScorer(LeafReaderContext context) throws IOException { if (docIdSet == null) { if (policy.shouldCache(in.getQuery())) { - docIdSet = cache(context); - putIfAbsent(in.getQuery(), docIdSet, cacheHelper); + boolean cacheSynchronously = executor == null; + // If asynchronous caching is requested, perform the same and return + // the uncached iterator + if (cacheSynchronously == false) { + cacheSynchronously = cacheAsynchronously(context, cacheHelper); Review comment: we need to update this similarly to what we did with `scorerSupplier`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org