jpountz commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/916#discussion_r334581927
########## File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java ########## @@ -813,6 +840,19 @@ public BulkScorer bulkScorer(LeafReaderContext context) throws IOException { if (docIdSet == null) { if (policy.shouldCache(in.getQuery())) { + boolean cacheSynchronously = executor == null; + // If asynchronous caching is requested, perform the same and return + // the uncached iterator + if (cacheSynchronously == false) { + boolean asyncCachingSucceeded = cacheAsynchronously(context, cacheHelper); + + // If async caching failed, we will perform synchronous caching + // hence do not return the uncached value here + if (asyncCachingSucceeded == false) { Review comment: ```suggestion if (asyncCachingSucceeded) { ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org