[ https://issues.apache.org/jira/browse/LUCENE-8979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrien Grand resolved LUCENE-8979. ---------------------------------- Fix Version/s: 8.4 Resolution: Fixed Thanks [~KoenDG]. > Code Cleanup: Use entryset for map iteration wherever possible - part 2 > possible. > --------------------------------------------------------------------------------- > > Key: LUCENE-8979 > URL: https://issues.apache.org/jira/browse/LUCENE-8979 > Project: Lucene - Core > Issue Type: Improvement > Affects Versions: 8.2 > Reporter: Koen De Groote > Priority: Trivial > Fix For: 8.4 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > For some reason, not all issues had been picked up in the previous ticket. > This should be all of them. My bad I suppose. > > ========================== > > Simple, non-important code cleanup. > Again, to clarify, please don't bother yourself with this ticket on company > time, on personal time you could be working on something that makes you money > or improves the product for your feature personally. > > This entire ticket is an afterthough. A look back at the code base that most > people don't have the time for. > > ================ > > While true that using `entrySet()` is really only an improvement for > traversing a TreeMap(at least that's how it was in JDK8), it's a good > practice in general to use it over keySet(), if you then use that keyset to > do an extra lookup to get the value as well as the key. > > So that's what this ticket is. > > All changes were done automatically via Intellij's built-in code analysis. > > Putting this on LUCENE because code both in lucene and solr was changed. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org