jimczi commented on issue #923: LUCENE-8988: Introduce Global Feature Based Early Termination For Sorted Fields URL: https://github.com/apache/lucene-solr/pull/923#issuecomment-541856947 > The minimum score is only applicable for indices that are sorted by relevance, whereas this change enables early terminating segments that are non competitive for all sort keys (irrespective of whether they are sorted by relevance or not) ? That's the part that I don't really understand. For sorted indices, early termination will require to visit only a few documents per segment so I wonder if the extra checks will make a difference or if they will simply slow down everything due to contention. As said above, we have a way to skip group of documents efficiently when sorted by relevancy but for other sort we can just bypass some checks in the priority queue. I am not sure that we'll gain anything with a synchronized call on every hit. I could be convinced otherwise but we'll need some benchmark to verify that the change really brings something. > Note that the update of global score can be done as a checkpoint as suggested by @jpountz in a separate thread, but I believe that can be done as a follow up change. I'd prefer that we find the best way to do this and then push to master. As it is there is no proof that the change brings anything and I'd like to commit #904 first so that you can build on top of it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
