sigram commented on a change in pull request #959: SOLR-13677 fix & cleanup URL: https://github.com/apache/lucene-solr/pull/959#discussion_r335863614
########## File path: solr/core/src/java/org/apache/solr/update/SolrIndexWriter.java ########## @@ -135,8 +135,7 @@ private SolrIndexWriter(SolrCore core, String name, String path, Directory direc infoStream = getConfig().getInfoStream(); this.directory = directory; numOpens.incrementAndGet(); - metricManager = core.getCoreContainer().getMetricManager(); - registryName = core.getCoreMetricManager().getRegistryName(); + solrMetricsContext = core.getSolrMetricsContext().getChildContext(this); Review comment: Similar situation to `SolrIndexSearcher`, the life-cycle here is different from SolrCore. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org