sigram commented on issue #959: SOLR-13677 fix & cleanup URL: https://github.com/apache/lucene-solr/pull/959#issuecomment-543130400 Regarding scope - in many places the SolrMetricsContext instance can be created once in the parent and then used for many components that differ only in their scope. Passing one common instance + component-specific scope seemed more efficient than creating new component-specific context for each component just because the scope was different ... but I'm not strongly attached to this change if you have strong arguments otherwise.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
