[ https://issues.apache.org/jira/browse/SOLR-13824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955121#comment-16955121 ]
Mikhail Khludnev commented on SOLR-13824: ----------------------------------------- Summary: * fixed incorrect json payload in several tests; * reveal at least three "assert masking" across tests * ObjectBuilder got new getValStrict() assuming (and even asserting) that correct json and only it is passed on input. * Utils.fromJSON() method now is strict. What's the enough pause to let every one who like review the patch? It's probably worth to ping [~arafalov] as a JSON practitioner. > JSON Request API ignores prematurely closing curly brace. > ---------------------------------------------------------- > > Key: SOLR-13824 > URL: https://issues.apache.org/jira/browse/SOLR-13824 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: JSON Request API > Reporter: Mikhail Khludnev > Priority: Major > Attachments: SOLR-13824.patch, SOLR-13824.patch, SOLR-13824.patch, > SOLR-13824.patch > > > {code:java} > json={query:"content:foo", facet:{zz:{field:id}}} > {code} > this works fine, but if we mistype {{}}} instead of {{,}} > {code:java} > json={query:"content:foo"} facet:{zz:{field:id}}} > {code} > It's captured only partially, here's we have under debug > {code:java} > "json":{"query":"content:foo"}, > {code} > I suppose it should throw an error with 400 code. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org