dsmiley commented on issue #953: LUCENE-9006: WDGF catenateAll should come before parts URL: https://github.com/apache/lucene-solr/pull/953#issuecomment-547414442 I guess we disagree on what is "correct" and thus correctness is debatable. If GENERATE_NUMBER_PARTS=0, it seems reasonable that "8other" and "other" occupy the same position. The numbers become ignored noise like symbols. You said ... "in order to ensure that all nodes are reachable." Reading that implies that we have to do something to prevent an unreachable node... but at present it's _not_ apparent to me that we have such a problem to fix. *If* the effect of not generating a part should yield a position gap, and if the first part is non-generated, then I can see there would be a problem.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
