HoustonPutman commented on issue #984: SOLR-12217: Support shards.preference for individual shard requests URL: https://github.com/apache/lucene-solr/pull/984#issuecomment-551215512 Want to hear your opinion @tflobbe . So I changed the logic for [non-update/admin/v2 request routing](https://github.com/apache/lucene-solr/pull/984/files#diff-e188c2b5189b7a912c7c77b50beddf69L1102) to use core URLs instead of collection URLs, unless the request is querying multiple collections. In this way, if there are certain replicas on a host that you want to target you can make that distinction. However that does change the default behavior in a non-trivial way. The only place where I see this breaks any test is weirdly enough in the [Hadoop auth tests for sending a commit request](https://github.com/apache/lucene-solr/blob/master/solr/core/src/test/org/apache/solr/security/hadoop/TestSolrCloudWithHadoopAuthPlugin.java#L127). It seems that since the commit request is sent directly to a core, instead of the collection url, it is missing an additional count of unauthenticated requests.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
