[
https://issues.apache.org/jira/browse/SOLR-14003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989885#comment-16989885
]
Jason Gerlowski commented on SOLR-14003:
----------------------------------------
I don't have any problems with this change necessarily, but it's hard to judge
without any context. Can you explain the rationale here please? Is there
something wrong with the existing getState() and isActive() methods in
themselves? Is it part of a larger change you're working towards? etc.
> Refactor code to avoid reading state of replica from the data object
> ----------------------------------------------------------------------
>
> Key: SOLR-14003
> URL: https://issues.apache.org/jira/browse/SOLR-14003
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Noble Paul
> Priority: Major
>
> Deprecate
> * {{Replica#getState()}}
> * {{Replica#isActive()}}
> Use an implementation of {{ReplicaStateProvider}} to fetch the state
> {code:java}
> /**An implementation that fetches the state of each replica in a collection
> * and it also provides the leader of shards
> *
> */
> public interface ReplicaStateProvider {
> Replica.State getState(Replica replica);
> Replica getLeader(Slice slice);
> boolean isActive(Replica replica);
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
