gerlowskija commented on issue #1058: SOLR-13972: Warn about insecure settings on startup URL: https://github.com/apache/lucene-solr/pull/1058#issuecomment-563324800 Few review comments there is no disagreement on: 1. Change a method name. 2. Change a link referenced in the log message. I'll make both those changes. Since there's disagreement on whether or not the suppress the message if localhost-binding is used, I'm going to keep it as is. I don't have strong opinions here though, so if Jan convinces people otherwise, I'm also happy to change it. Planning to update the patch today and merge it on Wednesday pending further review feedback.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
