bruno-roustant commented on issue #1070: LUCENE-9089: FST Builder fluent-style constructor. URL: https://github.com/apache/lucene-solr/pull/1070#issuecomment-564451408 Indeed it's a Builder pattern on a class named "Builder", which is odd. That's why I named the methods "construct" (instead of classical "new Builder") and "create" (instead of "build"). I agree with the FSTCompiler and FSTCompiler.Builder names. How do we manage a renaming? These classes are public. Right, they are "expert" and "experimental" but still public. Do we accept to rename them? In 9x only?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
