mkhludnev commented on a change in pull request #1034: SOLR-13863: payload query function now handles string encoded payload field (delimited_payloads_string) URL: https://github.com/apache/lucene-solr/pull/1034#discussion_r360661472
########## File path: solr/core/src/java/org/apache/solr/search/PayloadValueSource.java ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.search; + +import org.apache.lucene.queries.function.ValueSource; +import org.apache.lucene.util.BytesRef; + +public abstract class PayloadValueSource extends ValueSource { + protected final String field; + protected final String val; + protected final String indexedField; + protected final BytesRef indexedBytes; + protected final ValueSource defaultValueSource; + + public PayloadValueSource(String field, String val, String indexedField, BytesRef indexedBytes, ValueSource defaultValueSource) { + this.field = field; + this.val = val; + this.indexedField = indexedField; + this.indexedBytes = indexedBytes; + this.defaultValueSource = defaultValueSource; + } + +// public abstract SortField getSortField(boolean reverse); + + // TODO: should this be formalized at the ValueSource level? Seems to be the convention + public abstract String name(); + + @Override + public abstract String description(); + + @Override + public boolean equals(Object o) { + if (this == o) return true; + if (o == null || getClass() != o.getClass()) return false; + + PayloadValueSource that = (PayloadValueSource) o; + + if (!indexedField.equals(that.indexedField)) return false; + if (indexedBytes != null ? !indexedBytes.equals(that.indexedBytes) : that.indexedBytes != null) return false; + return defaultValueSource.equals(that.defaultValueSource); + + } + + @Override + public int hashCode() { Review comment: How it will be supported by descendants? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
