joel-bernstein commented on a change in pull request #1108: SOLR-14125 : Streaming expressions to be loadable from packages URL: https://github.com/apache/lucene-solr/pull/1108#discussion_r360722642
########## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/expr/StreamFactory.java ########## @@ -24,8 +24,8 @@ import java.util.HashMap; import java.util.List; import java.util.Locale; -import java.util.Map; import java.util.Map.Entry; +import java.util.function.Supplier; Review comment: Why the use of the Supplier? Is this a cosmetic change or is there some functionality here that I'm not seeing? I'm not against a cosmetic change but changes to StreamFactory are going to slow down landing this patch quite a bit because it's such an important class for Streaming Expressions. So if it's purely cosmetic and we want to land the other changes faster, let's do this in another ticket. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
