janhoy commented on a change in pull request #1124: SOLR-14151 :Schema components to be loadable from packages URL: https://github.com/apache/lucene-solr/pull/1124#discussion_r361411570
########## File path: solr/core/src/java/org/apache/solr/schema/IndexSchema.java ########## @@ -1981,4 +2089,10 @@ public PayloadDecoder getPayloadDecoder(String field) { return decoders.computeIfAbsent(ft, f -> PayloadUtils.getPayloadDecoder(ft)); } + @Override + public void close() throws IOException { + if (pluginLoader instanceof PackageAwarePluginLoader) { Review comment: Why the instanceof check here? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org