dsmiley commented on a change in pull request #1109: More pervasive use of
PackageLoader / PluginInfo
URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361586269
##########
File path: solr/core/src/java/org/apache/solr/core/PluginBag.java
##########
@@ -140,11 +139,10 @@ public static void initInstance(Object inst, PluginInfo
info) {
log.debug("{} : '{}' created with startup=lazy ", meta.getCleanTag(),
info.name);
return new LazyPluginHolder<T>(meta, info, core,
core.getResourceLoader(), false);
} else {
- if (info.pkgName != null) {
- PackagePluginHolder<T> holder = new PackagePluginHolder<>(info, core,
meta);
- return holder;
+ if (core.getResourceLoader().getPackage(info.pkgName) != null) {
Review comment:
> The idea of SRL trying to resolve the correct package is wrong.
You seem pretty adamant about this; I suggest saying you don't like that
approach instead of it being "wrong". In this PR, SRL resolving the package is
a central theme and so if we don't agree on wether SRL should do this then this
PR has no future (ah well). Maybe we will return to this idea if there are
holes in other approaches.
I view the lack of correct version resolution in the PR (still only one
commit as I write this) as merely a necessary TODO, and I don't forsee it'd be
hard. If you would like me to explore adding this next, let me know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
