dsmiley commented on a change in pull request #1124: SOLR-14151 :Schema 
components to be loadable from packages
URL: https://github.com/apache/lucene-solr/pull/1124#discussion_r361777912
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/core/MemClassLoader.java
 ##########
 @@ -53,6 +53,16 @@ public MemClassLoader(List<PluginBag.RuntimeLib> libs, 
SolrResourceLoader resour
     this.libs = libs;
   }
 
+  @Override
+  public <T> T newInstance(String cname, Class<T> expectedType, String... 
subpackages) {
+    return null;
 
 Review comment:
   I suggest adding "nocommit" strings to remind us there is work to do

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to