dsmiley commented on a change in pull request #1123: LUCENE-9093: Unified highlighter with word separator never gives context to the left URL: https://github.com/apache/lucene-solr/pull/1123#discussion_r361830391
########## File path: solr/solrj/src/java/org/apache/solr/common/params/HighlightParams.java ########## @@ -47,6 +47,8 @@ // sizing public static final String FRAGSIZE = HIGHLIGHT+".fragsize"; // OH, FVH, UH + public static final String FRAGALIGNRATIO = HIGHLIGHT+".fragAlignRatio"; // UH + public static final String FRAGSIZEISMINIMUM = HIGHLIGHT+".fragsizeIsMinimum"; // UH Review comment: very minor: I'd prefer these two added rows are switched so that fragsizeIsMinimum directly follows fragsize ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
