dweiss commented on issue #1163: SOLR-14186: Enforce CRLF in Windows files with .gitattributes URL: https://github.com/apache/lucene-solr/pull/1163#issuecomment-574074888 You assume a single "git" but there are multiple versions of the tool and even multiple implementations (jgit, for example). An assumption editors support or understand .gitattributes (or .editorconfig) is probably overly optimistic either... Not that I use nodepad.exe... but I'm sure there are folks who do! :) And more seriously: I've experimented with both options in the past and I use them in other projects but still prefer an explicit check for sanity. Ideally an integration test that takes the final ZIP/TGZ bundle and verifies distribution sanity - this also covers the (not unlikely) possibility of build tools messing up files while doing content-filtering, copying, whatever else.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
