[ https://issues.apache.org/jira/browse/SOLR-14248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032431#comment-17032431 ]
Shalin Shekhar Mangar commented on SOLR-14248: ---------------------------------------------- This patch fixes all the problems except for #5. The way it fixes #3 is a hack but that's the best I could do without creating a builder class for DocCollection. I've left a todo comment in there to describe the hack and eventual fix. > Improve ClusterStateMockUtil and make its methods public > -------------------------------------------------------- > > Key: SOLR-14248 > URL: https://issues.apache.org/jira/browse/SOLR-14248 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Tests > Reporter: Shalin Shekhar Mangar > Assignee: Shalin Shekhar Mangar > Priority: Minor > Fix For: master (9.0), 8.5 > > Attachments: SOLR-14248.patch > > > While working on SOLR-13996, I had the need to mock the cluster state for > various configurations and I used ClusterStateMockUtil. > However, I ran into a few issues that needed to be fixed: > 1. The methods in this class are protected making it useful only within the > same package > 2. A null router was set for DocCollection objects > 3. The DocCollection object is created before the slices so the > DocCollection.getActiveSlices method returns empty list because the active > slices map is created inside the DocCollection constructor > 4. It did not set core name for the replicas it created > 5. It has no support for replica types so it only creates nrt replicas > I will use this Jira to fix these problems and make the methods in that class > public (but marked as experimental) -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org